Recommendations for common pitfalls I keep coming back to [v5]

Not sure if this is the right place to ask, mods please remove if it is not. This came up at a meetup recently and the room was split, so curious what the broader community thinks.

The trade-offs here are not obvious to me and I keep flip-flopping. I tried three different approaches and none of them felt quite right.

Been thinking about this for a while and curious what the community thinks. The trade-offs here are not obvious to me and I keep flip-flopping.